Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Fixes #2361

Merged
merged 10 commits into from
Nov 13, 2024
Merged

General Fixes #2361

merged 10 commits into from
Nov 13, 2024

Conversation

kumarpalsinh25
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 commented Nov 11, 2024

  1. Fixes, New pin icon doesnt refresh on space overview
    Commit: f7a4d0a
Pin.Icon.mov
  1. Fixes, Keyboard overlay issue when do Add Task from Quick Action Buttons
    Commit: 5ea4214
Add.Task.mov
  1. Fixes, News: foreground & link color almost never work together
    Commit: 77f051d
News.Post.Colors.mov
  1. Fixes, Small space changes
    Commit: 0cfca17
Space.Overview.-.Name.and.Order.Chnage.mov
  1. Fixes, Swiping Boost Slides difficult on desktop
    Commit: becf82f
Boost.Scroll.-.Desktop.mov

6)Fixes, Event list order is not based on bookmark priority
Commit : ac27243

Bookmark.event.Priority.mov

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.14%. Comparing base (6baf18d) to head (3507b29).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
- Coverage   27.15%   27.14%   -0.01%     
==========================================
  Files         601      602       +1     
  Lines       41763    41780      +17     
==========================================
+ Hits        11340    11342       +2     
- Misses      30423    30438      +15     
Flag Coverage Δ
integration-test 36.91% <ø> (+<0.01%) ⬆️
unittest 18.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumarpalsinh25 kumarpalsinh25 marked this pull request as ready for review November 13, 2024 04:10
@gnunicorn
Copy link
Contributor

I don't see how you think 77f051d would fix #1704 the contrast is still way to low and bad. The word "link" is barely legible.

I think we need a different approach there.

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, just two minor remarks.

taskList: taskList,
taskName: taskName,
builder: (context) => Padding(
padding: MediaQuery.of(context).viewInsets,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curios ... why is that not needed in other cases? Is it because the object then pulls the auto-focus? But others should be doing that, too, no? I'd like to understand the cause here ...

Or should we wrap that in a safe-area?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know exact root cause. I also faced similar kind of issue where I developer createEditTitle common widget where it was working fine on some area and misbehave at some places.

Above code just fixed the issue earlier also so applied it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also confirm that wrapping with safe-area doesn't fixed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... that is unsatisfying ... would be good to figure out the root cause at some point...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm true, let me check if I can figure out something

app/lib/features/events/providers/event_providers.dart Outdated Show resolved Hide resolved
@kumarpalsinh25
Copy link
Contributor Author

I don't see how you think 77f051d would fix #1704 the contrast is still way to low and bad. The word "link" is barely legible.

I think we need a different approach there.

For now, I removed color which causing issue in visibility of link colors. Open for any better solution / suggestions.

@gnunicorn gnunicorn merged commit aaa6ad9 into main Nov 13, 2024
22 of 23 checks passed
@gnunicorn gnunicorn deleted the kumar/general-fixes branch November 13, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants